Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read default output @cds-models from package.json #416

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Read default output @cds-models from package.json #416

merged 7 commits into from
Dec 2, 2024

Conversation

daogrady
Copy link
Contributor

@daogrady daogrady commented Dec 2, 2024 •
edited
Loading

Change default value for outputDirectory from ./ to ./@cds-models when executed in a CAP project.

This PR does not include changing the default for the target model files to "*".

@daogrady daogrady requested review from Akatuoro and chgeo December 2, 2024 14:11
Akatuoro
Akatuoro approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Akatuoro Akatuoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected (cli option > project package.json > default) 👍

@daogrady daogrady merged commit bdecc94 into main Dec 2, 2024
18 checks passed
@daogrady daogrady deleted the feat/default-output-directory branch December 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akatuoro Akatuoro Akatuoro approved these changes

@chgeo chgeo chgeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daogrady @Akatuoro @chgeo